[Spice-devel] [PATCH spice-html5 2/2] main: Add event to alert file transfer error messages

[Jeremy White]

Hi Tomáš,


On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:
> ---
>  main.js         | 15 +++++++++++++++
>  spice.html      |  5 +++++
>  spice_auto.html |  5 +++++
>  3 files changed, 25 insertions(+)
> 
> diff --git a/main.js b/main.js
> index 0237f0e..447177b 100644
> --- a/main.js
> +++ b/main.js
> @@ -385,20 +385,25 @@ SpiceMainConn.prototype.handle_file_xfer_status = function(file_xfer_status)
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_ERROR:
>              xfer_error = "some errors occurred in the spice agent";
> +            this.file_xfer_detailed_errors(xfer_error);
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_SUCCESS:
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_NOT_ENOUGH_SPACE:
>              xfer_error = "not enough space in the remote system";
> +            this.file_xfer_detailed_errors(xfer_error);
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED:
>              xfer_error = "remote system is locked";
> +            this.file_xfer_detailed_errors(xfer_error);
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_AGENT_NOT_CONNECTED:
>              xfer_error = "spice angent is not connected";

Mind fixing this typo when you get a second?

> +            this.file_xfer_detailed_errors(xfer_error);
>              break;
>          case VD_AGENT_FILE_XFER_STATUS_DISABLED:
>              xfer_error = "file transfer is disabled on the remote system";
> +            this.file_xfer_detailed_errors(xfer_error);
>              break;
>          default:
>              xfer_error = "unhandled status type: " + file_xfer_status.result;
> @@ -506,3 +511,13 @@ SpiceMainConn.prototype.relative_now = function()
>      var ret = (Date.now() - this.our_mm_time) + this.mm_time;
>      return ret;

Why not also alert for unhandled errors and for cases where the transfer
was canceled by the agent?  In other words, why not just a:
  if (file_xfer_status.result != VD_AGENT_FILE_XFER_STATUS_SUCCESS)
?

Cheers,

Jeremy