[Spice-devel] [PATCH spice-html5 2/4] Display: Implement change preferred compression message

[Jeremy White]

Hi Tomáš,

Just as an aside, this work is greatly appreciated, and broadly quite
nice; please take my nit picking as a compliment and my attempt to help.

And I only have one nit on this one:

On 09/07/2017 02:18 AM, Tomáš Bohdálek wrote:
> ---
>  display.js  | 16 ++++++++++++++++
>  enums.js    | 10 ++++++++++
>  spicemsg.js | 20 ++++++++++++++++++++
>  3 files changed, 46 insertions(+)
> 
> diff --git a/display.js b/display.js
> index 7719b23..60c79b4 100644
> --- a/display.js
> +++ b/display.js
> @@ -1245,3 +1245,19 @@ function listen_for_video_events(stream)
>      if (STREAM_DEBUG > 1)
>          video_2_events.forEach(video_debug_listen_for_one_event, stream.video);
>  }
> +
> +SpiceDisplayConn.prototype.change_preferred_compression = function(compression_id)
> +{
> +    var ch = this.channel_type();
> +    if (!this.channel_test_capability(SPICE_DISPLAY_CAP_PREF_COMPRESSION))
> +    {
> +        this.log_warn(ch + " does not have capability to change the preferred compression");
> +        return;
> +    }
> +
> +    var msg = new SpiceMiniData();
> +    var compression = new SpiceMsgcDisplayPreferredCompression(compression_id);
> +
> +    msg.build_msg(SPICE_MSGC_DISPLAY_PREFERRED_COMPRESSION, compression);
> +    this.send_msg(msg);
> +}

Would you mind putting this function higher in the file, perhaps after
SpiceDisplayConn.prototype.destroy_surfaces?  I'd like to keep all of
the globally name spaced functions together (so we can fix them later :-/).

Cheers,

Jeremy