[Spice-devel] [PATCH spice-html5 v2 1/3] cursor: Add support for mono cursor type

[Jeremy White]

Hi Tomáš,

Teeny nit - your subject line implies that there are 2 more patches to
come.  I'm guessing the subject line is in error, not that there are
missing patches.  Is that right?

Some thoughts on the license, and an ack, below.

> diff --git a/spice_auto.html b/spice_auto.html
> index 2f04fc9..10f5508 100644
> --- a/spice_auto.html
> +++ b/spice_auto.html
> @@ -54,6 +54,7 @@
>          <script src="thirdparty/prng4.js"></script>
>          <script src="thirdparty/rng.js"></script>
>          <script src="thirdparty/sha1.js"></script>
> +        <script src="thirdparty/monocursor.js"></script>
>          <script src="ticket.js"></script>
>          <script src="resize.js"></script>
>          <script src="filexfer.js"></script>
> diff --git a/thirdparty/monocursor.js b/thirdparty/monocursor.js
> new file mode 100644
> index 0000000..36ebd88
> --- /dev/null
> +++ b/thirdparty/monocursor.js
> @@ -0,0 +1,100 @@
> +/*  Downloaded 1/6/2017 from https://github.com/eyeos/spice-web-client/blob/master/lib/graphic.js by Tomáš Bohdálek.
> +
> +License reproduce here for completeness:
> +
> + eyeOS Spice Web Client
> +Copyright (c) 2015 eyeOS S.L.
> +
> +Contact Jose Carlos Norte (jose at eyeos.com) for more information about this software.
> +
> +This program is free software; you can redistribute it and/or modify it under
> +the terms of the GNU Affero General Public License version 3 as published by the
> +Free Software Foundation.
> +
> +This program is distributed in the hope that it will be useful, but WITHOUT
> +ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
> +FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
> +details.
> +
> +You should have received a copy of the GNU Affero General Public License
> +version 3 along with this program in the file "LICENSE".  If not, see 
> +<http://www.gnu.org/licenses/agpl-3.0.txt>.
> +
> +See www.eyeos.org for more details. All requests should be sent to licensing at eyeos.org
> +
> +The interactive user interfaces in modified source and object code versions
> +of this program must display Appropriate Legal Notices, as required under
> +Section 5 of the GNU Affero General Public License version 3.
> +
> +In accordance with Section 7(b) of the GNU Affero General Public License version 3,
> +these Appropriate Legal Notices must retain the display of the "Powered by
> +eyeos" logo and retain the original copyright notice. If the display of the 
> +logo is not reasonably feasible for technical reasons, the Appropriate Legal Notices
> +must display the words "Powered by eyeos" and retain the original copyright notice.

I am not a lawyer, so I may be interpreting things incorrectly here.

But my understanding from the FSF FAQ is that the main difference
between the AGPL and the GPLv3 is that the AGPL will require someone
hosting a spice-html5 instance to provide an offer of source code to
anyone using the interface.  I don't think that's especially material;
as implemented now, all of the javascript is available from the hosting
web server as it is.

I had some concern that the specific Legal Notices clause could cause us
some pain; on the face of it, the worry is that we would have to place
'Powered by eyeos' on spice-html5.  I would find that unacceptable.

However, this small slice of the eyeos project has no user interface, so
it would seem to be exempt from that requirement.

Given that, and given that this code appears to be correct, consider
this acked-by Jeremy White <jwhite at codeweavers.com>.

Cheers,

Jeremy