[Spice-devel] [PATCH spice-gtk 0/5] Fix introspection method bindings

Matthew Francis mjay.francis at gmail.com
Tue Sep 19 05:49:53 UTC 2017


Various C functions have not been named correctly to be picked up as bound
methods under introspection. This renames them to ensure correct binding.

Outline:
 - Rename incorrectly named functions
 - Introduce deprecated wrappers for the original function names
 - Update in-tree references to use the new functions
 - Update gtk-doc for the new functions

For MainChannel, some existing functions are already wrappers that merely add
an extra boolean to another function. Rather than further layering another
wrapper on top of these, they are also deprecated in favour of the inner
functions.
 - spice_main_set_display()
   -> spice_main_channel_update_display(..., TRUE)
 - spice_main_set_display_enabled()
   -> spice_main_channel_update_display_enabled(..., TRUE)

Patch 1/5 supersedes the patch "Adjust SpicePortChannel method names" (not
identical to the original patch - the new version adds a required gtk-doc
update)


Matthew Francis (5):
  PortChannel: Fix introspection method bindings
  DisplayChannel: Fix introspection method bindings
  RecordChannel: Fix introspection method bindings
  InputsChannel: Fix introspection method bindings
  MainChannel: Fix introspection method bindings

 doc/reference/spice-gtk-sections.txt |  28 ++++
 src/channel-display.c                |  92 +++++++++++-
 src/channel-display.h                |  22 ++-
 src/channel-inputs.c                 | 146 +++++++++++++++++-
 src/channel-inputs.h                 |  34 ++++-
 src/channel-main.c                   | 283 +++++++++++++++++++++++++++++++----
 src/channel-main.h                   |  99 ++++++++----
 src/channel-port.c                   |  67 ++++++++-
 src/channel-port.h                   |  15 ++
 src/channel-record.c                 |  19 +++
 src/channel-record.h                 |   6 +
 src/map-file                         |  30 ++++
 src/spice-glib-sym-file              |  30 ++++
 src/spice-gstaudio.c                 |   2 +-
 src/spice-gtk-session.c              |  30 ++--
 src/spice-widget-egl.c               |   2 +-
 src/spice-widget.c                   |  71 +++++----
 tools/spicy.c                        |  41 ++---
 18 files changed, 870 insertions(+), 147 deletions(-)

-- 
2.7.4



More information about the Spice-devel mailing list