[Spice-devel] [PATCH spice-server] red-channel-client: Do not push items adding them to tail

[Frediano Ziglio]

> 
> On Tue, Sep 19, 2017 at 08:33:04AM -0400, Frediano Ziglio wrote:
> > > 
> > > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote:
> > > > Now the push is done automatically when a PipeItem is added
> > > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363
> > > > "worker: push data when clients can receive them"),
> > > > forcing a push cause only network fragmentation and is required only if
> > > > you are handling data in a polling loop (and thus, you are preventing
> > > > the default event loop from running).
> > > 
> > > I'd reword the shortlog to just "channel-client: Remove
> > > red_channel_client_pipe_add_tail_push"
> > > 
> > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > > Should something similar be done with
> > > red_channel_client_pipe_add_push()?
> > > 
> > > Christophe
> > > 
> > 
> > I have a patch like this for red_channel_client_pipe_add_push.
> 
> Ok, I was just curious, not directly related to the ack'ing or not of
> the current patch :) Thanks for the details !
> 
> Christophe
> 

Actually I was expecting somebody coming and explaining the reason :-)
Maybe I should post the patch with the red_channel_client_push call.

Frediano