[Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

[Christophe de Dinechin]

> On 20 Sep 2017, at 16:51, Christophe Fergeau <cfergeau at redhat.com> wrote:
> 
> On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote:
>>> 
>>>> The benefit of doing it that way (in addition to requiring less source code
>>>> changes and making following rebases or merge much easier) is that it leaves
>>>> the option to instrument spice allocations specifically when the need
>>>> arises.
>>>> 
>>> 
>>> There are many tools to instruments memory allocations and is not hard
>>> to write one on your own. For instance knowing that objects file takes
>>> precedence over libraries you can write a module defining malloc, or use
>>> --wrap linker option or LD_PRELOAD.
>> 
>> That works if you want to instrument all malloc calls. If you want to do
>> something specific to spice, you can’t do that.
> 
> You could do that with systemtap for example. And I really don't think
> we should have our spice_xxx wrappers for library calls.

But then, we don’t need g_xxx wrappers either, do we?

Anyway, if we were starting to write the code, I’d agree. But here, we do a big patch
just to remove the *existing* wrapper, including changes at practically all call sites.
That means a future rebase is going to show potential conflicts all over the place.
For everybody with branches that touch anything close to one of these call sites.

So the question is: how does putting a macro wrapper not solve the
alleged problem with having a wrapper, whatever that problem is, without
requiring all call sites to be modified?


Christophe

> 
> Christophe
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel