[Spice-devel] [PATCH vdagent 01/11] Bump GLib version to 2.34

[Daniel P. Berrange]

On Wed, Sep 27, 2017 at 06:23:36AM -0400, Frediano Ziglio wrote:
> > 
> > This is required for the following GMainLoop integration,
> > which utilizes some of the new functions/definitions, namely:
> > 
> > [definition][GLib version]
> > g_clear_pointer()   2.34
> > G_SOURCE_REMOVE     2.32
> > G_SOURCE_CONTINUE   2.32
> > g_unix_signal_add() 2.30
> 
> Which distribution are we going to not support?
> Surely RHEL 6 which we should support till 2021 (not considering
> extended support).

It is only neccessary to support a distro if there's a reasonable
liklihood the new versions of spice code will actually be used
in some way on that distro. Initially with RHEL major versions
it is fairly common to rebase virt software packages to new releases,
but as the age of the distro increases the liklihood of rebasing
drops. Already RHEL-6 is pretty much in bug-fix mode and is unlikely
to see rebases to new software releases.

Even without rebases, it might be worth keeping compat with RHEL-6
to facilitate bug fix backports, if there are a significant number
of bugs that are still planned to be fixed in that release.

If there's no significant bug backlog though, it is reasonable to
consider dropping RHEL-6 support before EOL date, if the benefit
of using newer glib without writing compat wrappers is compelling.


> 
> Can we write some compatibility code?
> g_clear_pointer is just a macro, we have a compatible macro in
> spice-server.
> G_SOURCE_REMOVE and G_SOURCE_CONTINUE are just TRUE/FALSE renamed
> in recent GLib.
> g_unix_signal_add maybe not too difficult to write a compatible
> GSource.
> 
> > ---
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index fbc20a9..d92b527 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],
> >                [enable_static_uinput="$enableval"],
> >                [enable_static_uinput="no"])
> >  
> > -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])
> > +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
> >  PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
> >  PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
> >  PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|