[Spice-devel] [spice-gtk v1 2/2] spice-widget: fix leak of boxed type cursor-shape

[Victor Toso]

On Wed, Apr 04, 2018 at 05:01:16AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > No valgrind on this one but a leak similar to previous patch.
> > This one was introduced in e691954be459087
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  src/spice-widget.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > index b60ca2b..1b79ad3 100644
> > --- a/src/spice-widget.c
> > +++ b/src/spice-widget.c
> > @@ -2993,6 +2993,7 @@ static void channel_new(SpiceSession *s, SpiceChannel
> > *channel, gpointer data)
> >          g_object_get(G_OBJECT(channel), "cursor", &cursor_shape, NULL);
> >          if (cursor_shape != NULL) {
> >              cursor_set(d->cursor, NULL, display);
> > +            g_boxed_free(spice_cursor_shape_get_type(), cursor_shape);
> >          }
> >          return;
> >      }
> 
> Why not using SPICE_TYPE_CURSOR_SHAPE ?

Ah, yes, that's better!

> You can release cursor_shape even before calling cursor_set.

Indeed. I'll move it up and send a v2.
Thanks for the review,

        toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180404/e3a77d52/attachment.sig>