[Spice-devel] [PATCH spice-gtk 3/3] fixup! Gstreamer: Use GstVideoOverlay if possible

Frediano Ziglio fziglio at redhat.com
Sun Apr 15 19:12:18 UTC 2018


limit appsink_cbs visibility
---
 src/channel-display-gst.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 6103fcb..2166f0f 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -357,7 +357,6 @@ static void app_source_setup(GstElement *pipeline G_GNUC_UNUSED,
 
 static gboolean create_pipeline(SpiceGstDecoder *decoder)
 {
-    GstAppSinkCallbacks appsink_cbs = { NULL };
     GstBus *bus;
 #if GST_CHECK_VERSION(1,9,0)
     GstElement *playbin, *sink;
@@ -456,8 +455,9 @@ static gboolean create_pipeline(SpiceGstDecoder *decoder)
     decoder->appsink = GST_APP_SINK(gst_bin_get_by_name(GST_BIN(decoder->pipeline), "sink"));
 #endif
 
-    appsink_cbs.new_sample = new_sample;
     if (decoder->appsink) {
+        GstAppSinkCallbacks appsink_cbs = { NULL };
+        appsink_cbs.new_sample = new_sample;
         gst_app_sink_set_callbacks(decoder->appsink, &appsink_cbs, decoder, NULL);
     }
     bus = gst_pipeline_get_bus(GST_PIPELINE(decoder->pipeline));
-- 
2.14.3



More information about the Spice-devel mailing list