[Spice-devel] [PATCH spice-gtk 3/4] gio-coroutine: Remove only assigned self field

[Christophe Fergeau]

Alternatively, this could come first in the series, with the nice
side-effect of fixing that GSource inheritance issue that you mentioned
;) With the order that you chose, this allows to make the fix more
obvious, and to better document why it was not a problem (by luck).

On Fri, Apr 13, 2018 at 03:49:18PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/gio-coroutine.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/gio-coroutine.c b/src/gio-coroutine.c
> index 86623c3..59ae06c 100644
> --- a/src/gio-coroutine.c
> +++ b/src/gio-coroutine.c
> @@ -25,7 +25,6 @@
>  typedef struct _GConditionWaitSource
>  {
>      GSource parent; // this MUST be the first field
> -    GCoroutine *self;
>      GConditionWaitFunc func;
>      gpointer data;
>  } GConditionWaitSource;
> @@ -167,7 +166,6 @@ gboolean g_coroutine_condition_wait(GCoroutine *self, GConditionWaitFunc func, g
>  
>      vsrc->func = func;
>      vsrc->data = data;
> -    vsrc->self = self;
>  
>      self->condition_id = g_source_attach(src, NULL);
>      g_source_set_callback(src, g_condition_wait_helper, self, NULL);
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180416/660e3498/attachment.sig>