[Spice-devel] [spice-server 01/10] qxl: Remove red_put_blend()

Frediano Ziglio fziglio at redhat.com
Mon Apr 16 10:45:34 UTC 2018


> 
> SpiceBlend is a typedef to SpiceCopy, and red_put_blend() and
> red_put_copy() are identical, so we can add a #define red_put_blend
> red_put_copy similar to the one we already have for red_get_blend.
> ---
>  server/red-parse-qxl.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c
> index 9f1303da3..b766e9935 100644
> --- a/server/red-parse-qxl.c
> +++ b/server/red-parse-qxl.c
> @@ -712,12 +712,7 @@ static void red_put_copy(SpiceCopy *red)
>  
>  // these types are really the same thing
>  #define red_get_blend_ptr red_get_copy_ptr
> -
> -static void red_put_blend(SpiceBlend *red)
> -{
> -    red_put_image(red->src_bitmap);
> -    red_put_qmask(&red->mask);
> -}
> +#define red_put_blend red_put_copy
>  
>  static void red_get_transparent_ptr(RedMemSlotInfo *slots, int group_id,
>                                      SpiceTransparent *red, QXLTransparent
>                                      *qxl,

Acked, coherent also with red_get_blend_ptr and red_put_copy is just
some lines above

Frediano


More information about the Spice-devel mailing list