[Spice-devel] [spice-server 05/10] qxl: Rename 'qxl' to 'qxl_cmd' in red_get_cursor_cmd()

Frediano Ziglio fziglio at redhat.com
Mon Apr 16 12:38:00 UTC 2018


> 
> On Mon, Apr 16, 2018 at 06:58:18AM -0400, Frediano Ziglio wrote:
> > Don't like this, lot of structures in this file use "qxl", for coherence
> > I would change all or nothing but changing all would mean a lot of changes
> > with not much value
> 
> Imo 'red' and 'qxl' are not very good names, I'd prefer to have them
> named red_cmd and qxl_cmd. I agree it's quite a few changes though. I
> can send an initial patch changing all of these if you prefer.
> 
> Christophe
> 

I would personally keep red and qxl and add a qxl_instance.

Frediano


More information about the Spice-devel mailing list