[Spice-devel] [PATCH] build: Remove check for pnp.ids path

[Victor Toso]

Hi,

On Mon, Apr 16, 2018 at 05:44:14PM -0300, Eduardo Lima (Etrunko) wrote:
> This looks like a leftover from the following commit, which removed the
> only reference for this file.
> 
> commit 30986505ba6041c293c38cb4b7f4b618a59f4716
> Author: Marc-André Lureau <marcandre.lureau at redhat.com>
> Date:   Fri May 10 17:05:49 2013 +0200
> 
>     Remove GnomeRR code
> 
>     Changing client resolution is a bad idea, and never took up.
>     Remove some unmaintained experimental code.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  configure.ac    | 15 ---------------
>  src/Makefile.am |  1 -
>  2 files changed, 16 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 17799c1..a9a7eb9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -164,21 +164,6 @@ CFLAGS="$old_CFLAGS"
>  PKG_CHECK_EXISTS([gtk+-x11-$with_gtk], [PKG_CHECK_MODULES(X11, x11)])
>  AC_CHECK_HEADERS([X11/XKBlib.h])
>  
> -AC_ARG_WITH([pnp-ids-path],
> -  AC_HELP_STRING([--with-pnp-ids-path],
> -                 [Specify the path to pnp.ids @<:@default=(internal)@:>@]),
> -  [],
> -  [with_pnp_ids_path="\${pnpdatadir}/pnp.ids"])
> -
> -AM_CONDITIONAL(USE_INTERNAL_PNP_IDS, test "x$with_pnp_ids_path" = "x\${pnpdatadir}/pnp.ids")
> -PNP_IDS=$with_pnp_ids_path
> -AC_SUBST(PNP_IDS)
> -if test "x$with_pnp_ids_path" = "x\${pnpdatadir}/pnp.ids"; then
> -        EXTERNAL_PNP_IDS="no (internal)"
> -else
> -        EXTERNAL_PNP_IDS="$with_pnp_ids_path"
> -fi
> -
>  AC_CHECK_FUNCS(clearenv strtok_r)
>  
>  # Keep these two definitions in agreement.
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1701cc6..f49c766 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -67,7 +67,6 @@ KEYMAP_CSV = keycodemapdb/data/keymaps.csv
>  SPICE_COMMON_CPPFLAGS =						\
>  	-DSPICE_COMPILATION					\
>  	-DG_LOG_DOMAIN=\"GSpice\"				\
> -	-DPNP_IDS=\""$(PNP_IDS)"\"				\
>  	-DUSB_IDS=\""$(USB_IDS)"\"				\
>  	-I$(top_srcdir)						\
>  	$(COMMON_CFLAGS)					\
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180417/f9ecd182/attachment.sig>