[Spice-devel] [spice-protocol v1 1/4] streaming: define max of number of concurrent streams

[Frediano Ziglio]

> 
> From: Victor Toso <me at victortoso.com>
> 
> This definition is lacking in client while in server it is hardcoded
> to 50. Having a well defined limitation allow us to make the code
> more robust and optimized.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  spice/protocol.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/spice/protocol.h b/spice/protocol.h
> index cbf2f01..12ba6c3 100644
> --- a/spice/protocol.h
> +++ b/spice/protocol.h
> @@ -45,6 +45,8 @@
>  #define SPICE_TICKET_KEY_PAIR_LENGTH 1024
>  #define SPICE_TICKET_PUBKEY_BYTES (SPICE_TICKET_KEY_PAIR_LENGTH / 8 + 34)
>  
> +#define SPICE_MAX_NUM_STREAMS 64
> +
>  typedef struct SPICE_ATTR_PACKED SpiceLinkHeader {
>      uint32_t magic;
>      uint32_t major_version;

Some more comments would be great I think, kind of

/*
 * This is the maximum number of streams possible.
 * IDs will be in the interval [0, SPICE_MAX_NUM_STREAMS).
 */

Not sure if this should be here or in common/messages.h.

Frediano