[Spice-devel] [PATCH spice-streaming-agent] Eliminate signed/unsigned warning

[Christophe Fergeau]

Hey,

I believe my comment from
https://lists.freedesktop.org/archives/spice-devel/2018-February/042062.html
still apply, by default -Wno-sign-compare is in the CFLAGS/CXXFLAGS, so
I'd mention in the log that you need to use non-default CXXFLAGS to hit
this. Apart from this, looks good to me.

Christophe

On Thu, Apr 19, 2018 at 02:24:23PM +0100, Frediano Ziglio wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/mjpeg-fallback.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp
> index 68c282f..e3de291 100644
> --- a/src/mjpeg-fallback.cpp
> +++ b/src/mjpeg-fallback.cpp
> @@ -47,7 +47,7 @@ private:
>      std::vector<uint8_t> frame;
>  
>      // last frame sizes
> -    uint32_t last_width = ~0u, last_height = ~0u;
> +    int last_width = -1, last_height = -1;
>      // last time before capture
>      uint64_t last_time = 0;
>  };
> @@ -70,7 +70,7 @@ MjpegFrameCapture::~MjpegFrameCapture()
>  void MjpegFrameCapture::Reset()
>  {
>      frame.clear();
> -    last_width = last_height = ~0u;
> +    last_width = last_height = -1;
>  }
>  
>  FrameInfo MjpegFrameCapture::CaptureFrame()
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180423/3db6006a/attachment.sig>