[Spice-devel] MR!3 patch

[Jon Stumpf]

Frediano,

Attached is the patch file as created by "git format-patch".  In reading
the documentation, git format-patch warns of the many problems using all
the email clients that I use.  And, frankly, I do not want to figure out
how to avoid these pitfalls.

This is becoming increasing difficult to submit such simple patches.  To
contribute,

   - I have had to subscribe to Gitlab (I am a Github user).
   - In using the WebIDE, it created a change set involving the whole file
   because it replaced the Windows EOL sequence with the UNIX EOL sequence.
   - I created Merge Requests but was directed to provide patches.
   - In providing patches, I was instructed to use "git format-patch"
   versus "git diff".

I understand that you have a development process (I have since read your
Developers page).  That understood, I don't intend to contribute beyond the
fixing of the bugs that I have discovered and attempted to rectify.  I am
Linux developer and do not have a Windows build environment.  (I had a
colleague test the compile on Windows 10.)

I have two small patches (MR!1 and MR!3) to address the issue I documented
in Issue #4.  If these patches do not work, I am asking that you choose one
of the following at this point:

   1. Use the Merge Requests already in your repo;
   2. Use the diff patches as a seed into your development process;

I would also like someone to answer the questions posed in Issue #4 and
also address the lack of documentation for the QXL parameters.

Thank you.

- jss


On Tue, Apr 24, 2018 at 8:01 AM, Jon Stumpf <jon.stumpf at gmail.com> wrote:

> Frediano,
>
> I will this evening when I return home and after I read how to use "git
> format-patch".
>
> - jss
>
>
> On Tue, Apr 24, 2018 at 7:00 AM, Frediano Ziglio <fziglio at redhat.com>
> wrote:
>
>> > Here is the patch for Merge Request 3 (MR!3). The WebIDE must have
>> changed
>> > the end-of-line sequence as I produced this with "git diff
>> > --ignore-all-space".
>>
>> > - jss
>>
>> Jon, can you provide patches in the form of git changes?
>> Instead of git diff you can use git format-patch.
>> Alternatively add some comment and email (I assume "Jon Stumpf" <
>> jon.stumpf at gmail.com>)
>> you want to see in the git commit.
>>
>> Frediano
>>
>
>
>
> --
> - jss
>
>


-- 
- jss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180424/9ebeae2a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MR1.patch
Type: text/x-patch
Size: 2057 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180424/9ebeae2a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MR3.patch
Type: text/x-patch
Size: 4845 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180424/9ebeae2a/attachment-0003.bin>