[Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

[Victor Toso]

Hi,

On Wed, Apr 25, 2018 at 04:26:40AM -0400, Frediano Ziglio wrote:
> > Besides avoiding regression... SpiceUsbDeviceManager is only
> > initialized on UI objects in spice-gtk. That should be fixed
> > at some point as non gtk tools like spicy-stats might do usb
> > redirection.
> > 
> > If this patches seems like good progress, I'll file a bug to
> > fix the critical that this patch set introduces, yes :)
> > 
> 
> If you propose a solution with a "if the patches seems like
> good progress" looks like you are not sure about it.

I know it is better then git master because they fix regression
while avoiding a crash

> You should propose good patches :-)

> > Cheers,
> >         toso
> > 
> > > > On Fri, Apr 06, 2018 at 09:59:43AM +0200, Victor Toso wrote:
> > > > > From: Victor Toso <me at victortoso.com>
> > > > > 
> > > > > This reverts commit 291f3e4419e6fb4077ae43a5e09eb1c37b9dd729
> > > > > 
> > > > > Follow up patch should address rhbz#1399838 mentioned in commit above
> > > > > in a different way.
> > > > > 
> > > > > Major reason to revert is that the SpiceUsbDeviceManager object is
> > > > > kept in SpiceSession as an easy way to share it between different
> > > > > SpiceUsbredirChannel while SpiceSession itself does not use it. This
> > > > > causes problems on migration as we start a new session with a new
> > > > > SpiceUsbDeviceManager object while the previous one still exists.
> > > > > 
> 
> Maybe SpiceUsbDeviceManager should be a global (singleton)
> meaning that you should not create a new object but just add a
> reference to it even from another SpiceSession?

Maybe. I'm pretty sure there is a better fix, yes.

        toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180425/5f0aa839/attachment.sig>