[Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

[Eduardo Lima (Etrunko)]

On 26/04/18 12:43, Frediano Ziglio wrote:
>>
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  src/Makefile.am           | 5 -----
>>  src/spice-channel-enums.h | 7 -------
>>  2 files changed, 12 deletions(-)
>>  delete mode 100644 src/spice-channel-enums.h
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index d2a749c..c6b76d4 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -302,11 +302,6 @@ nodist_libspice_client_glibinclude_HEADERS =	\
>>  	spice-glib-enums.h			\
>>  	$(NULL)
>>  
>> -# file for API compatibility, but we don't want warning during our
>> compilation
>> -dist_libspice_client_glibinclude_DATA =	\
>> -	spice-channel-enums.h		\
>> -	$(NULL)
>> -
>>  if HAVE_PULSE
>>  libspice_client_glib_2_0_la_SOURCES +=	\
>>  	spice-pulse.c			\
>> diff --git a/src/spice-channel-enums.h b/src/spice-channel-enums.h
>> deleted file mode 100644
>> index 02df762..0000000
>> --- a/src/spice-channel-enums.h
>> +++ /dev/null
>> @@ -1,7 +0,0 @@
>> -#ifndef SPICE_CHANNEL_ENUMS_H
>> -#define SPICE_CHANNEL_ENUMS_H
>> -
>> -#warning "deprecated: please include spice-glib-enums.h"
>> -#include "spice-glib-enums.h"
>> -
>> -#endif /* SPICE_CHANNEL_ENUMS_H */
> 
> Acked with delay (just couple of days maybe)
> 

Sure, this can wait.

> In my system, is in spice-glib-devel package, there's no spec on the repository
> so packages will have to remove the file.
> 
> Maybe would be good to state that this file was deprecated more than 7
> years ago (commit d27f761325b356c91bda1ca60186d4613d6933d2).
> 

I will send a v2 later with the message referencing this commit.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com