[Spice-devel] [PATCH libcacard 08/45] hex_dump: Helper function to allow inspection of internal buffers

[Jakub Jelen]

On Tue, 2018-07-31 at 23:58 +0200, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jul 31, 2018 at 11:53 PM, Marc-André Lureau
> <marcandre.lureau at gmail.com> wrote:
> > Hi
> > 
> > On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen at redhat.com>
> > wrote:
> > > Signed-off-by: Jakub Jelen <jjelen at redhat.com>
> > > Reviewed-by: Robert Relyea <rrelyea at redhat.com>
> > 
> > This isn't used in your tree, let's not add dead code.
> 
> My bad, the function is called hex_dump(), that confused me (usually
> it's hexdump, like the command)
> 
> > 
> > fwiw, there are more elegant implementations we could adopt if
> > needed,
> > like  _g_dbus_hexdump() in glib.
> 
> let's use your implementation for now

I was searching for a function from glib under debug/logging functions,
but not under the dbus.

Jakub