[Spice-devel] [PATCH libcacard 09/45] Adjust PKI Applet to CAC 2

[Jakub Jelen]

On Wed, 2018-08-01 at 00:16 +0200, Marc-André Lureau wrote:
> Hi Jakub,
> 
> On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen at redhat.com>
> wrote:
> >  * This involves creation of properties structures in the applet,
> >    that are used to discover pki buffers in the applet and its
> >    properties.
> >  * This also removes the old way of accessing certificates using
> >    GET CERTIFICATE APDU
> > 
> > Signed-off-by: Jakub Jelen <jjelen at redhat.com>
> > Reviewed-by: Robert Relyea <rrelyea at redhat.com>
> > ---
> 
> Starting from this patch, make check fails.
> 
> It eventually get fixed by later patch "tests: GP Card Manager and
> responses on SELECT APDU"
> 
> but then tests/hwtest keeps failing.

I tweaked the code and tests to pass and rebased remaining commits on
top of current master and I will resend them.

The memcheck is not clean, especially in later phases when both NSS and
SoftHSM come into the play, but the tests are passing now.

Regards,
-- 
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.