[Spice-devel] [spice-gtk 2/2] flatpak: Move to 3.26 runtime version

Victor Toso victortoso at redhat.com
Mon Aug 6 13:52:25 UTC 2018


Hi,

On Mon, Aug 06, 2018 at 09:47:51AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > As we have OPUS in 3.26, which means audio playback.
> 
> I don't know why it does not sound that great, maybe my English.

I'll put it as "3.26 runtime was release $date and includes Opus
which enables playback audio in flatpack"

> 
> > This patch also changes the git url to gitlab.
> > 
> 
> Can you split? Not hard with git-gui or similar tool

I can't see a strong reason to split it but I don't really mind.
I'll send it later today.

Thanks for review,


> 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  data/org.spicespace.spicy.json | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
> > index 064b9a6..7243508 100644
> > --- a/data/org.spicespace.spicy.json
> > +++ b/data/org.spicespace.spicy.json
> > @@ -1,7 +1,7 @@
> >  {
> >      "app-id": "org.spicespace.spicy",
> >      "runtime": "org.gnome.Platform",
> > -    "runtime-version": "3.24",
> > +    "runtime-version": "3.26",
> >      "sdk": "org.gnome.Sdk",
> >      "command": "spicy",
> >      "tags": ["devel", "development", "nightly"],
> > @@ -46,7 +46,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url":
> > "git://anongit.freedesktop.org/spice/spice-protocol"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-protocol.git"
> >                  }
> >              ]
> >          },
> > @@ -63,7 +63,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-gtk.git"
> >                  }
> >              ]
> >          }
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180806/3fefbeff/attachment.sig>


More information about the Spice-devel mailing list