[Spice-devel] [spice-gtk v2] usb-device-manager: Set UsbDk backend on libusb 1.0.22

Frediano Ziglio fziglio at redhat.com
Tue Aug 7 10:25:05 UTC 2018


> 
> Hi,
> 
> On Tue, Aug 07, 2018 at 06:02:41AM -0400, Frediano Ziglio wrote:
> > > 
> > > From: 王凡 <wangfan1987.good at 163.com>
> > > 
> > > In libusb 1.0.21, UsbDk is enabled at compile time with --enable-usbdk
> > > option. In libusb 1.0.22, the backend is selected at runtime.
> > > 
> > > This patch avoids a crash when spice client is compiled against libusb
> > > 1.0.22 and UsbDk is not installed.
> > > 
> > > * Enabling dynamic backend selection in Windows
> > > https://github.com/libusb/libusb/commit/54884e84d024e761450287ab56aca
> > > 
> > > https://gitlab.freedesktop.org/spice/spice-gtk/issues/74
> > > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > 
> > No signed off by 王凡 (I know is the author) ?
> 
> Is it a hard requirement when the person is author of patch?
> 
> Regards,
> Victor
> 

Not sure, that's why the question. In some cases the signed-off is used
for licenses issues (like saying "I, the author, allow the owner to change
license" or something similar).

Frediano


More information about the Spice-devel mailing list