[Spice-devel] [spice-server] build: Use <> rather than "" for including spice-server-enums.h
Lukáš Hrázký
lhrazky at redhat.com
Wed Aug 8 11:09:51 UTC 2018
Acked-by: Lukáš Hrázký <lhrazky at redhat.com>
On Wed, 2018-08-08 at 12:54 +0200, Christophe Fergeau wrote:
> When using #include "spice-server-enums.h", it will be looked up first
> in the directory containing the file being build, which is going to be
> $srcdir when dcc.c includes it. However, spice-server-enums.h is a
> generated file, so it will be in $builddir, not in $srcdir. This most of
> the time won't be causing any problems, except when you happen to have
> an invalid spice-server-enums.h in $srcdir and you are doing an
> out-of-tree build.
> Using #include <spice-server-enums.h> instead allows the correct
> spice-server-enums.h file to be looked up.
>
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
> server/dcc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/dcc.c b/server/dcc.c
> index 0468e7213..826dd28fe 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -24,7 +24,7 @@
> #include "display-channel-private.h"
> #include "red-client.h"
> #include "main-channel-client.h"
> -#include "spice-server-enums.h"
> +#include <spice-server-enums.h>
> #include "glib-compat.h"
>
> G_DEFINE_TYPE(DisplayChannelClient, display_channel_client, TYPE_COMMON_GRAPHICS_CHANNEL_CLIENT)
More information about the Spice-devel
mailing list