[Spice-devel] [spice-server PATCH] Remove unused structs QXLDrawArea and QXLDevInfo

Jonathon Jongsma jjongsma at redhat.com
Thu Aug 9 18:36:49 UTC 2018


On Thu, 2018-08-09 at 19:49 +0300, Uri Lublin wrote:
> The structure usage was removed from commit
>   2ba69f9f8819daaa3d166c4c1c7e03b121b88a95
>   ("libspice: add surface 0 support").
> 
> They were never used by Qemu.
> 
> Signed-off-by: Uri Lublin <uril at redhat.com>
> Acked-by: Frediano Ziglio <fziglio at redhat.com>

Seems it was acked already? Does it need another Ack?


> ---
>  server/spice-qxl.h | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/server/spice-qxl.h b/server/spice-qxl.h
> index 04c657c58..0c4e75fc2 100644
> --- a/server/spice-qxl.h
> +++ b/server/spice-qxl.h
> @@ -115,26 +115,6 @@ void spice_qxl_gl_draw_async(QXLInstance
> *instance,
>                               uint32_t w, uint32_t h,
>                               uint64_t cookie);
>  
> -typedef struct QXLDrawArea {
> -    uint8_t *buf;
> -    uint32_t size;
> -    uint8_t *line_0;
> -    uint32_t width;
> -    uint32_t heigth;
> -    int stride;
> -} QXLDrawArea;
> -
> -typedef struct QXLDevInfo {
> -    uint32_t x_res;
> -    uint32_t y_res;
> -    uint32_t bits;
> -    uint32_t use_hardware_cursor;
> -
> -    QXLDrawArea draw_area;
> -
> -    uint32_t ram_size;
> -} QXLDevInfo;
> -
>  typedef struct QXLDevInitInfo {
>      uint32_t num_memslots_groups;
>      uint32_t num_memslots;


More information about the Spice-devel mailing list