[Spice-devel] [PATCH spice-gtk v4 0/3] Add support for building with meson/ninja

[Eduardo Lima (Etrunko)]

On 10/08/18 17:26, Victor Toso wrote:
> Hi,
> 
> On Fri, Aug 10, 2018 at 04:23:45PM -0300, Eduardo Lima (Etrunko) wrote:
>> in v4:
>>  - New patch renaming vncdisplaykeymap_*.c to .h
>>  - Fix parallel builds by adding generated keymap files as dependency
>>    of spice_client_gtk library.
> 
> Yep, seems to work fine although I think you missed to remote
> -Wcast-function-type as done in
> https://gitlab.freedesktop.org/spice/spice-gtk/commit/8bb24c57209db1

I have added this locally, but it seems to be something with recent gcc,
because it fails with the one I have here, 7.3.1 (still running Fedora 27):

cc1: warning: unrecognized command line option ‘-Wno-cast-function-type’

I will update the meson patch to make use of
compiler.get_supported_arguments()

http://mesonbuild.com/Reference-manual.html#compiler-object

> 
> I don't think you need an extra version for that. Let's use it by
> default and improve what might be necessary during this release
> timeline.
> 
> I haven't poked yet around mingw builds with meson but I know it
> can be done (...) - For the series:
> 
> Acked-by: Victor Toso <victortoso at redhat.com>
> 
> But I'd wait till Monday to push to see if anyone has different
> opinion on the generated keymap files being renamed.
> 
> Cheers,
> Victor
> 
>> Eduardo Lima (Etrunko) (3):
>>   Rename generated vncdisplaykeymap_*.c files to .h
>>   Add support for building with meson/ninja
>>   Update gitlab-ci to use meson
>>
>>  .gitlab-ci.yml                     |  22 +-
>>  Makefile.am                        |   4 +
>>  build-aux/meson/check-spice-common |   5 +
>>  data/Makefile.am                   |   1 +
>>  data/meson.build                   |   4 +
>>  doc/Makefile.am                    |   2 +
>>  doc/meson.build                    |   1 +
>>  doc/reference/Makefile.am          |   2 +
>>  doc/reference/meson.build          |  51 +++++
>>  man/Makefile.am                    |   1 +
>>  man/meson.build                    |  11 +
>>  meson.build                        | 446 +++++++++++++++++++++++++++++++++++++
>>  meson_options.txt                  | 102 +++++++++
>>  po/meson.build                     |   3 +
>>  src/Makefile.am                    |  29 +--
>>  src/meson.build                    | 360 ++++++++++++++++++++++++++++++
>>  src/vncdisplaykeymap.c             |  14 +-
>>  subprojects/spice-common           |   2 +-
>>  tests/Makefile.am                  |   2 +
>>  tests/meson.build                  |  30 +++
>>  tools/Makefile.am                  |   2 +
>>  tools/meson.build                  |  32 +++
>>  vapi/Makefile.am                   |   1 +
>>  vapi/meson.build                   |  13 ++
>>  24 files changed, 1117 insertions(+), 23 deletions(-)
>>  create mode 100755 build-aux/meson/check-spice-common
>>  create mode 100644 data/meson.build
>>  create mode 100644 doc/meson.build
>>  create mode 100644 doc/reference/meson.build
>>  create mode 100644 man/meson.build
>>  create mode 100644 meson.build
>>  create mode 100644 meson_options.txt
>>  create mode 100644 po/meson.build
>>  create mode 100644 src/meson.build
>>  create mode 100644 tests/meson.build
>>  create mode 100644 tools/meson.build
>>  create mode 100644 vapi/meson.build
>>
>> -- 
>> 2.14.4
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/spice-devel


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com