[Spice-devel] [cacard 1/5] hex_dump: Remove unused arguments

[Christophe Fergeau]

Hey,

On Tue, Aug 21, 2018 at 05:30:50PM +0200, Jakub Jelen wrote:
> On Tue, 2018-08-21 at 17:03 +0200, Christophe Fergeau wrote:
> > hex_dump() callers can theoretically provide the destination buffer
> > for the hexdump'ed string, but nothing in libcacard uses that
> > feature.
> > This commit removes it.
> 
> The initial idea was to create some g_debug_hex function that could use
> that with dynamic allocation, but that never happened. It does not make
> sense to ship dead code.

On the dynamic allocation front, I experimented with
https://gitlab.com/teuf/libcacard/commit/472ad2e6df31472120e0d22d
together with a DUMP_BUFFER macro wrapping the allocation/freeing of the
buffer, but still unsure this is the right way forward... ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180822/e651fd3a/attachment.sig>