[Spice-devel] [PATCH libcacard v2 26/35] tests: Make sure we do not crash on bad data to sign

Jakub Jelen jjelen at redhat.com
Wed Aug 22 16:19:37 UTC 2018


On Wed, 2018-08-22 at 17:53 +0200, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Aug 21, 2018 at 06:52:28PM +0200, Jakub Jelen wrote:
> > [...]
> > 
> > I tried to improve this part a bit with comments and local
> > variable,
> > but if the above helped you to understand the issue, you can
> > improve
> > the code and comments.
> 
> Yes, this is clearer with this explanation.. And the patch looks
> good/fixes my -fsanitize=address issues. I'd change the memcpy to
> memmove though. Feel free to push this with a commit log :)

Thanks,
pushed as

https://gitlab.freedesktop.org/spice/libcacard/commit/03d3dd6

Jakub



More information about the Spice-devel mailing list