[Spice-devel] [PATCH spice-server] fixup! Add support for building with meson/ninja

[Frediano Ziglio]

> 
> Now calculating the soversion the same way it is done by libtool,
> instead of using the resulting number directly.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  meson.build | 29 +++++++++++++++++++++++++++--
>  1 file changed, 27 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 5ca3e1cc..2db2a953 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -17,9 +17,34 @@ endif
>  message('Updating submodules')
>  run_command('build-aux/meson/check-spice-common', check : true)
>  
> -# some global vars
> -spice_server_so_version = '1.12.4'
>  
> +#
> +# soversion
> +# The versioning is defined by the forumla (CURRENT-AGE.AGE.REVISION)
> +#
> +# XXX: KEEP IN SYNC WITH configure.ac file

Really minor: I personally prefer TODO instead of XXX, XXX reminds
me some peculiar movies, but is just preference, feel free to ignore

> +#
> +# Follow the libtool manual for the so version:
> +#
> http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> +# - If the library source code has changed at all since the last update,
> +#   then increment revision (‘c:r:a’ becomes ‘c:r+1:a’).
> +# - If any interfaces have been added, removed, or changed since the last
> update,
> +#   increment current, and set revision to 0.
> +# - If any interfaces have been added since the last public release,
> +#   then increment age.
> +# - If any interfaces have been removed or changed since the last public
> release,
> +#   then set age to 0.
> +#
> +#
> +spice_server_current = 13
> +spice_server_revision = 5
> +spice_server_age = 12
> +spice_server_so_version = '@0 at .@1 at .@2@'.format(spice_server_current -
> spice_server_age,
> +                                               spice_server_age,
> +                                               spice_server_revision)
> +message('libspice.so version: ' + spice_server_so_version)

Other minor: is this just for debug?

> +
> +# some global vars
>  spice_server_global_cflags = ['-fvisibility=hidden',
>                                '-DSPICE_SERVER_INTERNAL',
>                                '-DG_LOG_DOMAIN="Spice"',

Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>

I think this was the last comment of the big patch, I would
personally say that I would merge (the big one with this).
I would just wait a day if somebody has some last objections.

Frediano