[Spice-devel] [PATCH spice-common v2] meson: Make use of compiler.get_supported_arguments()

Eduardo Lima (Etrunko) etrunko at redhat.com
Thu Aug 30 15:04:31 UTC 2018


On 08/30/2018 11:58 AM, Eduardo Lima (Etrunko) wrote:
> This avoids adding an extra build flag which may not be supported by the
> compiler.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  meson.build | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 6fa67dc..5729d12 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -159,9 +159,8 @@ glib_encoded_version = 'GLIB_VERSION_ at 0@_ at 1@'.format(glib_major_minor[0], glib_m
>  spice_common_global_cflags += ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version),
>                                 '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)]
>  
> -foreach arg : spice_common_global_cflags
> -  add_project_arguments(arg, language : 'c')
> -endforeach
> +add_project_arguments(compiler.get_supported_arguments(spice_common_global_cflags),
> +                      language : 'c')
>  

This can also be done for spice-server and spice-gtk, I am sending
patches for them.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com


More information about the Spice-devel mailing list