[Spice-devel] [PATCH spice-gtk] spice-widget: Remove useless return statement

Frediano Ziglio fziglio at redhat.com
Wed Dec 5 09:17:16 UTC 2018


> On 11/29/18 3:42 PM, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  src/spice-widget.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > index 312c640a..9bb42211 100644
> > --- a/src/spice-widget.c
> > +++ b/src/spice-widget.c
> > @@ -2994,8 +2994,6 @@ static void channel_new(SpiceSession *s, SpiceChannel
> > *channel, SpiceDisplay *di
> >          return;
> 
> Isn't this one here useless as well?
> 

Didn't notice. Yes, currently useless too, I think is here in a sort
of coherent

if (this) {
   handle this
   return;
}
if (that) {
   handle that
   return;
}
....

> >      }
> >  #endif
> > -
> > -    return;
> >  }
> >  
> >  static void channel_destroy(SpiceSession *s, SpiceChannel *channel,
> >  SpiceDisplay *display)
> > 
> 
> 

Frediano


More information about the Spice-devel mailing list