[Spice-devel] [spice-gtk v1 3/4] gtk-session: remove single goto usage
Victor Toso
victortoso at redhat.com
Wed Dec 5 15:52:43 UTC 2018
From: Victor Toso <me at victortoso.com>
Returning TRUE here should be fine. Not much error handling around the
label.
Signed-off-by: Victor Toso <victortoso at redhat.com>
---
src/spice-gtk-session.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
index 1615172..bf3c1fb 100644
--- a/src/spice-gtk-session.c
+++ b/src/spice-gtk-session.c
@@ -813,8 +813,9 @@ static gboolean clipboard_grab(SpiceMainChannel *main, guint selection,
if (read_only(self) ||
!s->auto_clipboard_enable ||
- s->nclip_targets[selection] == 0)
- goto skip_grab_clipboard;
+ s->nclip_targets[selection] == 0) {
+ return TRUE;
+ }
if (!gtk_clipboard_set_with_owner(cb, targets, i,
clipboard_get, clipboard_clear, G_OBJECT(self))) {
@@ -824,7 +825,6 @@ static gboolean clipboard_grab(SpiceMainChannel *main, guint selection,
s->clipboard_by_guest[selection] = TRUE;
s->clip_hasdata[selection] = FALSE;
-skip_grab_clipboard:
return TRUE;
}
--
2.19.2
More information about the Spice-devel
mailing list