[Spice-devel] qxl: Move more guest resource release to red-parse-qxl

Frediano Ziglio fziglio at redhat.com
Thu Dec 6 13:42:12 UTC 2018


> 
> Hey,
> 
> Currently, after parsing a QXL command through red-parse-qxl, the code which
> got the command has to tell red-parse-qxl when it no longer needs the
> command, but also to remember to release the command QXL resources
> itself. This series moves this 'release resource' logic to
> red-parse-qxl. This also changes all the parsed QXL commands to use
> _new/_ref/_unref in order to have a consistent API.
> 
> Changes since v3:
> - rebased on top of master
> - dropped the last 3 patches which were RFC and did not get any
>   feedback. I'll resend once this series has moved forward.
> 
> Changes since v2:
> - switched all QXL command parsing to use _new/_ref/_unref
> - added new patches doing this for RedSurfaceCmd
> - added patches introducing RedQXLGuestResources and using QXLCommandExt in
>   red-parse-qxl.h interface
> 
> Changes since v1:
> - moved renaming patch to the end, and made it much more extensive
> - added a new patch unifying identical methods
> - reworked 'qxl: Fix guest resources release in red_put_drawable()' so that
> it's similar to
>   the cursor changes
> 
> Christophe
> 

Acked the series with minor changes (spaces, line breaks and some function
orders).

Frediano


More information about the Spice-devel mailing list