[Spice-devel] [PATCH spice-gtk 2/3] fixup! Gstreamer: Control GstVideoOverlay from the widget

[Frediano Ziglio]

> 
> Hi,
> 
> On 12/17/18 11:51 AM, Frediano Ziglio wrote:
> > ---
> >   src/channel-display.c   |  2 ++
> >   src/spice-widget-priv.h |  3 +--
> >   src/spice-widget.c      | 51 ++++++++++++++++-------------------------
> >   3 files changed, 23 insertions(+), 33 deletions(-)
> >
> > diff --git a/src/channel-display.c b/src/channel-display.c
> > index 6b6a172c..e63fb3bb 100644
> > --- a/src/channel-display.c
> > +++ b/src/channel-display.c
> > @@ -29,7 +29,9 @@
> >   #include "spice-session-priv.h"
> >   #include "channel-display-priv.h"
> >   #include "decode.h"
> > +#ifdef HAVE_GSTVIDEO
> >   #include "gst/gst.h"
> > +#endif
> >   
> >   /**
> >    * SECTION:channel-display
> > diff --git a/src/spice-widget-priv.h b/src/spice-widget-priv.h
> > index 651d306e..0264577d 100644
> > --- a/src/spice-widget-priv.h
> > +++ b/src/spice-widget-priv.h
> > @@ -154,8 +154,7 @@ struct _SpiceDisplayPrivate {
> >   #endif // HAVE_EGL
> >       double scroll_delta_y;
> >   #ifdef HAVE_GSTVIDEO
> > -    GWeakRef                overlay_element_weak_ref;
> > -    GstPipeline             *pipeline;
> > +    GWeakRef overlay_weak_ref;
> 
> 
> The indentation is wrong in previous line, see attached patch
> 

See "Vertical indentation" at https://www.spice-space.org/spice-project-coding-style-and-coding-conventions.html,
if you are fixing the entire indentation fix with the current style, not an old one.

Frediano