[Spice-devel] [PATCH spice-common v2 1/2] test-region: Add missing dependencies
Frediano Ziglio
fziglio at redhat.com
Mon Dec 17 11:56:19 UTC 2018
>
> The test uses both GLib and pixman libraries.
> This does not seem to affect Linux but make the test fails under Windows.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> tests/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> Changes since v1:
> - use SPICE_COMMON_LIBS
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 926ac99..f54e394 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -63,6 +63,7 @@ test_region_CFLAGS = \
> $(NULL)
> test_region_LDADD = \
> $(top_builddir)/common/libspice-common.la \
> + $(SPICE_COMMON_LIBS) \
> $(NULL)
>
> # Avoid need for python(pyparsing) by end users
Looks like a bug in libtool. Dependencies are in libspice-common.la and
the real executable (in tests/.libs/test_region.exe) correctly depends
on glib and pixman dll files however the wrapper/launcher generated in
tests/test_region.exe is generated not considering dependencies in
libspice-common.la (one of wrapper job is to add some definitions to
PATH variable).
Still the patch solves the weird issue.
Frediano
More information about the Spice-devel
mailing list