[Spice-devel] [vdagent-linux v2 2/2] systemd: Remove WantedBy=sockets.service in [Install]

[Frediano Ziglio]

> 
> .socket systemd units already automatically get a
> Before=sockets.service, and the udev rule we have will ensure that when
> the appropriate virtio device is there, the socket unit will be started,
> so this WantedBy dependency is not needed, and is in part responsible
> for these warnings:
> 
> [ INFO ] dev-virtio\x2dports-com.redhat.spice.0.device is not active.
> [DEPEND] Dependency failed for Activation socket for spice guest agent
> daemon.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1545212
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
> New patch following initial discussion
> 
>  data/spice-vdagentd.socket | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/data/spice-vdagentd.socket b/data/spice-vdagentd.socket
> index f14e662..adace91 100644
> --- a/data/spice-vdagentd.socket
> +++ b/data/spice-vdagentd.socket
> @@ -3,6 +3,3 @@ Description=Activation socket for spice guest agent daemon
>  
>  [Socket]
>  ListenStream=/var/run/spice-vdagentd/spice-vdagent-sock
> -
> -[Install]
> -WantedBy=sockets.target

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Out of this patch but related. What will happen to systems during upgrade?
Will the dependency (sockets.target wants spice-vdagentd.socket) removed?
I suppose for RPM the script will do it, not sure about a possible
"make install" or Debian packages.

Frediano