[Spice-devel] [PATCH spice-server 32/33] Use structure for socket_t type instead of just a typedef

[Marc-André Lureau]

Hi

On Fri, Dec 21, 2018 at 4:04 PM Frediano Ziglio <fziglio at redhat.com> wrote:
>
> Allows the compiler to catch errors mixing int and sockets.
> Make easier to keep Windows port working.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Ah, I understand the debug code now.

Still, I think you are being overzealous. Please just use int, like
everybody else.


> ---
>  server/sys-socket.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/sys-socket.h b/server/sys-socket.h
> index 9dca563b..361845e2 100644
> --- a/server/sys-socket.h
> +++ b/server/sys-socket.h
> @@ -26,7 +26,7 @@
>  #ifndef _WIN32
>  #  include <sys/socket.h>
>
> -#if 0
> +#if ENABLE_EXTRA_CHECKS
>  typedef struct {
>      int fd;
>  } socket_t;
> --
> 2.17.2
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



--
Marc-André Lureau