[Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments
Frediano Ziglio
fziglio at redhat.com
Wed Feb 7 17:43:32 UTC 2018
>
> > On 7 Feb 2018, at 14:58, Frediano Ziglio <fziglio at redhat.com> wrote:
> >
> >>
> >> From: Christophe de Dinechin <dinechin at redhat.com>
> >>
> >> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> >> ---
> >> docs/spice_style.txt | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> >> index ccc60bb3..e35272ec 100644
> >> --- a/docs/spice_style.txt
> >> +++ b/docs/spice_style.txt
> >> @@ -293,6 +293,8 @@ default:
> >> }
> >> ----
> >>
> >> +Use /* Fall through */ comments when there is no break (compilers will
> >> emit
> >> a warning otherwise)
> >> +
> >> Types indentation
> >> ~~~~~~~~~~~~~~~~~
> >>
> >
> > This comment has not much to do with the "Branching indentation" section
> > beside is under a switch example
>
> Any other place where you would put it?
>
Was looking but it does not seem to be a good section for this.
I would add a new section kind of "switch" ? Maybe after "goto"?
I really didn't find any better place.
Frediano
More information about the Spice-devel
mailing list