[Spice-devel] [PATCH v2 03/13] Specify file extensions for C++ and Obj-C

Frediano Ziglio fziglio at redhat.com
Thu Feb 8 08:40:58 UTC 2018


> 
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  docs/spice_style.txt | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index c127f026..72ed2ef7 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -14,7 +14,16 @@ Names
>  
>  Use lower case and separate words using dashes (e.g., file-name.c,
>  header.h).
>  
> -Use standard file extension for C source and header files.
> +The file extensions used in the SPICE project are:
> +- .c for C source
> +- .cpp for C++ sources
> +- .h for headers that can be included from C code
> +- .hpp for headers that are strictly reserved to C++
> +- .m for Objective-C source files (currently not properly enforced)

I would remove the "(currently not properly enforced)" part, the style
is what we aim, not representing the current state (obviously the code
should try to be coherent to that but there are always exceptions
like "contrib" code just copied or incorporated from other projects").

> +
> +Note that .h headers may contain C++ code as long as the header can
> +sucessfully be included from a C source file.
> +
>  

"sucessfully" typo.

>  Line width
>  ~~~~~~~~~~

Frediano


More information about the Spice-devel mailing list