[Spice-devel] [PATCH v2 06/13] Rephrase section on short functions for readability

Frediano Ziglio fziglio at redhat.com
Thu Feb 8 08:50:37 UTC 2018


> 
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  docs/spice_style.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 3e463d2f..74f4e29d 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -113,7 +113,7 @@ If multiple related constants are to be defined, consider
> the use of enumeration
>  Short functions
>  ---------------
>  
> -Try to split code to short functions, each having simple functionality, in
> order to improve code readability and re-usability. Prefix with inline short
> functions or functions that were splitted for readability reason.
> +Try to split code to short functions, each having simple functionality, in
> order to improve code readability and re-usability. Prefix with `inline`
> functions that were splitted for readability reason or that are very short.
>  
>  Return on if
>  ------------

I really don't understanding the aiming of both version.
Is mixing the inline concept (optimization suggestion) with readability
and I don't understand the reason.

Frediano


More information about the Spice-devel mailing list