[Spice-devel] [PATCH v2 04/13] Rephrase assertion section

Lukáš Hrázký lhrazky at redhat.com
Thu Feb 8 09:21:14 UTC 2018


On Wed, 2018-02-07 at 12:07 +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  docs/spice_style.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 72ed2ef7..61cb0701 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -82,7 +82,11 @@ Comments that are prefixed with `FIXME` describe a bug that need to be fixed. Ge
>  ASSERT
>  ------
>  
> -Use it freely. ASSERT helps testing function arguments and function results validity.  ASSERT helps detecting bugs and improve code readability and stability.
> +Use assertions liberally. They helps testing function arguments and function results validity. Assertions helps detecting bugs and improve code readability and stability.

"They help", "Assertions help"

> +
> +Several form of assertion exist, notably:
> +- spice_assert which should be preferred for any assertion related to SPICE itself
> +- glib asserts (many forms) which should be preferred for any assertion related to the use of glib
>  
>  sizeof
>  ------


More information about the Spice-devel mailing list