[Spice-devel] [PATCH v2 12/13] Add guidelines about warnings and whitespaces

[Lukáš Hrázký]

On Thu, 2018-02-08 at 10:21 +0100, Victor Toso wrote:
> Hey,
> 
> On Thu, Feb 08, 2018 at 10:13:21AM +0100, Lukáš Hrázký wrote:
> > On Thu, 2018-02-08 at 04:02 -0500, Frediano Ziglio wrote:
> > > > 
> > > > From: Christophe de Dinechin <dinechin at redhat.com>
> > > > 
> > > > The objective of these guidelines is that:
> > > > - We avoid introducing new warnings
> > > > - We know how to fix old ones
> > > > - We don't have to isolate whitespace changes when submitting patches,
> > > >   i.e. someone who use tools that automatically strip whitespaces and
> > > >   therefore "repairs" earlier errors should not be punished for it.
> > > 
> > > Sorry, I don't agree with the automatic tool, patches should not
> > > contain extra changes unless they fix space changes while changing
> > > these lines for other reasons.
> > > I'll personally accept single patches fixing the spaces.
> > 
> > I'm with Frediano here. If you want to automatically fix whitespace
> > errors, you can do it in a separate commit without much effort?
> > 
> > I can also go right now and fix all trailing whitespaces with a bash
> > oneliner, submit the patch and we have a moot point here? :)
> 
> Well, it was nacked before :)
> 
> https://lists.freedesktop.org/archives/spice-devel/2016-May/029603.html

What is the reasoning behind the nack?

I'd rather have a style-only commit than to fight the bad indentation
manually and possibly have unrelated whitespace changes in another
patch...

By the way, mine got acked :D

https://lists.freedesktop.org/archives/spice-devel/2018-January/041527.html

Lukas