[Spice-devel] [PATCH v3 07/11] Remove confusing example

Frediano Ziglio fziglio at redhat.com
Mon Feb 12 08:22:14 UTC 2018


See https://lists.freedesktop.org/archives/spice-devel/2018-February/041727.html

> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> The sentence explaining that example makes no real sense, and
> the coding style suggestion is horrendous (not to mention flies in the
> face of all automatic indentation tools)
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  docs/spice_style.txt | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 486efbc9..68dbeeef 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -279,15 +279,7 @@ if (condition) {
>  +
>  In case of long condition statement, prefer having additional temporary
>  variable over multiple line condition statement.
>  +
> -In case of new line in condition statement.
> -+
> -[source,c]
> -----
> -if (long_name && very_long_name && very_long ||
> -                                               var_name) {
> -----
> -+
> -or indent under the round bracket using spaces
> +Indent long conditionals under the opening parenthesis using spaces
>  +
>  [source,c]
>  ----


More information about the Spice-devel mailing list