[Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

Frediano Ziglio fziglio at redhat.com
Wed Feb 14 15:45:56 UTC 2018


> 
> Shouldn't this go with a Makefile rule? A few lines in the log what this
> is about, what is the goal for having this file, ... would not hurt.
> 
> Christophe
> 

I think this file is supposed to just help developers so should not
be in the Makefile.
I think you mean that the intention should be written in the commit message.

> On Thu, Feb 08, 2018 at 12:25:21PM +0100, Christophe de Dinechin wrote:
> > From: Christophe de Dinechin <dinechin at redhat.com>
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> > ---
> >  .clang-format | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 .clang-format
> > 
> > diff --git a/.clang-format b/.clang-format
> > new file mode 100644
> > index 00000000..91203600
> > --- /dev/null
> > +++ b/.clang-format
> > @@ -0,0 +1,23 @@
> > +Language:        Cpp
> > +# BasedOnStyle:  LLVM
> > +
> > +# The following is commented out until widely supported
> > +# IncludeBlocks: Regroup
> > +SortIncludes: true
> > +
> > +IncludeCategories:
> > +  - Regex:           'config.h'
> > +    Priority:        -1
> > +  - Regex:           '^"spice.*"'
> > +    Priority:        1
> > +  - Regex:           'glib'
> > +    Priority:        4
> > +  - Regex:           '^<.*>'
> > +    Priority:        3
> > +  - Regex:           '^".*"'
> > +    Priority:        2
> > +
> > +ColumnLimit:     100
> > +IndentCaseLabels: false
> > +IndentWidth:     4
> > +BreakBeforeBraces: Linux

Frediano


More information about the Spice-devel mailing list