[Spice-devel] [PATCH 12/14] Get rid of C-style memset initializations, use C++ style aggregates

[Frediano Ziglio]

> 
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 43
>  ++++++++++++++++++++++++-------------------
>  1 file changed, 24 insertions(+), 19 deletions(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 9a5c4fa..a55e1a5 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -210,19 +210,22 @@ write_all(int fd, const void *buf, const size_t len)
>      return written;
>  }
>  
> -static int spice_stream_send_format(unsigned w, unsigned h, unsigned c)
> +static int spice_stream_send_format(unsigned w, unsigned h, uint8_t c)
>  {
> -
> -    SpiceStreamFormatMessage msg;
> -    const size_t msgsize = sizeof(msg);
> -    const size_t hdrsize  = sizeof(msg.hdr);
> -    memset(&msg, 0, msgsize);
> -    msg.hdr.protocol_version = STREAM_DEVICE_PROTOCOL;
> -    msg.hdr.type = STREAM_TYPE_FORMAT;
> -    msg.hdr.size = msgsize - hdrsize; /* includes only the body? */
> -    msg.msg.width = w;
> -    msg.msg.height = h;
> -    msg.msg.codec = c;
> +    const size_t msgsize = sizeof(SpiceStreamFormatMessage);
> +    const size_t hdrsize  = sizeof(StreamDevHeader);
> +    SpiceStreamFormatMessage msg = {
> +        .hdr = {
> +            .protocol_version = STREAM_DEVICE_PROTOCOL,
> +            .type = STREAM_TYPE_FORMAT,
> +            .size = msgsize - hdrsize
> +        },
> +        .msg = {
> +            .width = w,
> +            .height = h,
> +            .codec = c
> +        }
> +    };
>      syslog(LOG_DEBUG, "writing format\n");
>      std::lock_guard<std::mutex> stream_guard(stream_mtx);
>      if (write_all(streamfd, &msg, msgsize) != msgsize) {
> @@ -233,14 +236,16 @@ static int spice_stream_send_format(unsigned w,
> unsigned h, unsigned c)
>  
>  static int spice_stream_send_frame(const void *buf, const unsigned size)
>  {
> -    SpiceStreamDataMessage msg;
> -    const size_t msgsize = sizeof(msg);
>      ssize_t n;
> +    const size_t msgsize = sizeof(SpiceStreamFormatMessage);
> +    SpiceStreamDataMessage msg = {
> +        .hdr = {
> +            .protocol_version = STREAM_DEVICE_PROTOCOL,
> +            .type = STREAM_TYPE_DATA,
> +            .size = size  /* includes only the body? */
> +        }
> +    };
>  
> -    memset(&msg, 0, msgsize);
> -    msg.hdr.protocol_version = STREAM_DEVICE_PROTOCOL;
> -    msg.hdr.type = STREAM_TYPE_DATA;
> -    msg.hdr.size = size; /* includes only the body? */
>      std::lock_guard<std::mutex> stream_guard(stream_mtx);
>      n = write_all(streamfd, &msg, msgsize);
>      syslog(LOG_DEBUG,
> @@ -407,7 +412,7 @@ do_capture(const char *streamport, FILE *f_log)
>  
>              if (frame.stream_start) {
>                  unsigned width, height;
> -                unsigned char codec;
> +                uint8_t codec;
>  
>                  width = frame.size.width;
>                  height = frame.size.height;

This patch does not compile on gcc

Frediano