[Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

[Christophe Fergeau]

On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote:
> 
> 
> > On 14 Feb 2018, at 17:34, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote:
> >>> 
> >>> Shouldn't this go with a Makefile rule? A few lines in the log what this
> >>> is about, what is the goal for having this file, ... would not hurt.
> >>> 
> >>> Christophe
> >>> 
> >> 
> >> I think this file is supposed to just help developers so should not
> >> be in the Makefile.
> > 
> > Yes, after reading various threads, it's apparently meant to be used
> > together with emacs for formatting of small code blocks, it's not usable
> > on the whole codebase. So a 'make clang-format' rule apparently would
> > not make sense.
> > 
> >> I think you mean that the intention should be written in the commit message.
> > 
> > Yes, knowing how it's meant to be used, why we want it in the codebase.
> 
> Why would we NOT want it in the codebase?

I'm not saying I'm against what this patch is adding. I'm saying
I'm against a commit adding something without much of a rationale in its
commit log.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180215/176c7044/attachment.sig>