[Spice-devel] [PATCH spice-streaming-agent v3 0/3] first unit test and options parsing improvements

[Frediano Ziglio]

> 
> This series introduces a C++ unit test framework called Catch to the
> codebase, adds a simple unit test for the options parsing for the mjpeg
> plugin and improves on the option parsing code.
> 
> Since we more or less agreed we can solve the Catch package in RHEL one
> way or another, I suppose we can proceed here.
> 
> Changes since v1:
> - squash the two test patches and keep the BDD version
> - update for the explicit namespaces
> - use syslog instead of std::cerr for logging the error message
> - add temporary files to .gitignore
> 
> Changes since v2:
> - updated src/unittests/.gitignore
> - updated the subject for 1/3
> - fixed the namespace and Makefile.am so that the test actually compiles
> 
> Lukáš Hrázký (3):
>   mjpeg-fallback: a more high-level way of handling options
>   src/unitests: add temporary files to .gitignore
>   mjpeg-fallback: unittest for the options parsing
> 
>  configure.ac                          |  3 ++
>  src/mjpeg-fallback.cpp                | 46 ++++++++++++++-------------
>  src/mjpeg-fallback.hpp                |  1 +
>  src/unittests/.gitignore              |  4 +++
>  src/unittests/Makefile.am             | 15 +++++++++
>  src/unittests/test-mjpeg-fallback.cpp | 58
>  +++++++++++++++++++++++++++++++++++
>  6 files changed, 106 insertions(+), 21 deletions(-)
>  create mode 100644 src/unittests/test-mjpeg-fallback.cpp
> 

No comments beside follow ups, acked the series

Frediano