[Spice-devel] [PATCH v3 11/11] Rewrite the style guide for headers

[Christophe Fergeau]

On Thu, Feb 15, 2018 at 01:14:43PM +0100, Christophe de Dinechin wrote:
> 
> 
> > On 15 Feb 2018, at 10:19, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Wed, Feb 14, 2018 at 11:24:50PM +0100, Christophe de Dinechin wrote:
> >> 
> >> 
> >>> On 14 Feb 2018, at 14:35, Christophe Fergeau <cfergeau at redhat.com> wrote:
> >>> 
> >>> This one sounds more like an RFC to me
> >> 
> >> Well, this is really a bug fix in the documentation more than a RFC.
> >> 
> >>> , as from a quick look in server/,
> >>> this is not the style currently in use.
> >> 
> >> As I pointed out in earlier discussions, this section of the style guide, as written currently, is mostly backwards compared to industry best practices.
> >> 
> >> Most projects today put project headers first for a reason: it catches the frequent case where a header change makes it not self-contained (therefore making it possible to break third-party code using that header).
> >> 
> >> Examples of explicit recommendations to that effect from various heavyweights:
> > 
> > I haven't said I am against this style.... What I mean is that
> > spice-server is not following this style, as far as I can tell spice-gtk
> > is not either, so adding this now to the coding styles is just odd. It
> > should reflect at least a little bit what is currently being done ;)
> 
> Well, what is done is discussing style, knowing that the current style
> is not exceedingly consistent to start with, and in doing so. I
> pointed out things that are bogus in the existing guidelines. What’s
> wrong with that? That I’m criticizing your beloved codebase? ;-)

Even with the smiley, this is not funny nor helping the discussion.
Especially when the paragraph you quote starts with "I haven't said I am against
this style....".
All I'm saying is that it's very odd to me to push something to the
coding styles which does not match at all what is inconsistently being
done in the codebase at the moment. And then I made concrete suggestions
as how I would move forward with this patch...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180215/7fb2d7cd/attachment-0001.sig>