[Spice-devel] [PATCH v3 11/11] Rewrite the style guide for headers

Christophe Fergeau cfergeau at redhat.com
Thu Feb 15 14:59:20 UTC 2018


On Thu, Feb 15, 2018 at 03:25:08PM +0100, Christophe de Dinechin wrote:
> > And then I made concrete suggestions
> > as how I would move forward with this patch…
> 
> Sorry, I saw your push back, but I did not see the concrete suggestion for moving forward… Would you please be kind enough to rephrase it?

The last 2 paragraphs of https://lists.freedesktop.org/archives/spice-devel/2018-February/041930.html
Which you have actually more or less acknowledged by saying you forgot
to squash and need to send a v4 or something like that.
Given that this specific change does not match at all what we are
currently doing in the codebase, I'd emphasize this fact once more in
this section, even if it's already mentioned elsewhere in the document.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180215/87e52163/attachment.sig>


More information about the Spice-devel mailing list