[Spice-devel] [PATCH spice-gtk v2 1/4] session: warn with the original URI

Frediano Ziglio fziglio at redhat.com
Fri Feb 16 11:19:53 UTC 2018


> 
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> Before:
> (lt-spicy:18372): GSpice-WARNING **: 10:57:21.246: Double set of 'port' in
> URI 'spice://foo'
> 
> After:
> (lt-spicy:18654): GSpice-WARNING **: 10:57:21.246: Double set of 'port' in
> URI 'spice://foo:23?port=24'
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
>  src/spice-session.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spice-session.c b/src/spice-session.c
> index 2aabf58..e6db424 100644
> --- a/src/spice-session.c
> +++ b/src/spice-session.c
> @@ -545,7 +545,7 @@ static int spice_parse_uri(SpiceSession *session, const
> char *original_uri)
>          }
>          if (target_key) {
>              if (*target_key) {
> -                g_warning("Double set of '%s' in URI '%s'", key, uri);
> +                g_warning("Double set of '%s' in URI '%s'", key,
> original_uri);
>                  goto fail;
>              }
>              *target_key = g_uri_unescape_string(value, NULL);
> @@ -553,7 +553,7 @@ static int spice_parse_uri(SpiceSession *session, const
> char *original_uri)
>      }
>  
>      if (port == NULL && tls_port == NULL) {
> -        g_warning("Missing port or tls-port in spice URI '%s'", uri);
> +        g_warning("Missing port or tls-port in spice URI '%s'",
> original_uri);
>          goto fail;
>      }
>  

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list