[Spice-devel] [PATCH 02/17] log_binary is really a boolean

[Frediano Ziglio]

> 
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 4ec5e42..6056129 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -55,9 +55,9 @@ struct SpiceStreamDataMessage
>  
>  static bool streaming_requested = false;
>  static bool quit_requested = false;
> +static bool log_binary = false;
>  static std::set<SpiceVideoCodecType> client_codecs;
>  static int streamfd = -1;
> -static int log_binary = 0;
>  static std::mutex stream_mtx;
>  
>  static int have_something_to_read(int timeout)
> @@ -409,7 +409,7 @@ int main(int argc, char* argv[])
>      const char *log_filename = NULL;
>      int logmask = LOG_UPTO(LOG_WARNING);
>      struct option long_options[] = {

This can be static const now.

> -        { "log-binary", no_argument, &log_binary, 1},
> +        { "log-binary", no_argument, NULL, 'b'},
>          { "help", no_argument, NULL, 'h'},
>          { 0, 0, 0, 0}
>      };

I don't think this option deserve a short option.
Also the usage should be changed.

OT: "char opt" is a bug, not that of a problem.
The only bug I can see is somebody passing -$'\xff'
interpreted as a end of arguments.

> @@ -437,6 +437,9 @@ int main(int argc, char* argv[])
>              agent.AddOption(optarg, p);
>              break;
>          }
> +        case 'b':
> +            log_binary = true;
> +            break;
>          case 'l':
>              log_filename = optarg;
>              break;

Frediano